[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

Kendal Harland via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 15 10:35:07 PDT 2024


================
@@ -10,9 +10,10 @@
 
 
 class TestDAP_stepInTargets(lldbdap_testcase.DAPTestCaseBase):
-    @skipIf(
-        archs=no_match(["x86_64"])
-    )  # InstructionControlFlowKind for ARM is not supported yet.
+    @skipIf
+    # InstructionControlFlowKind for ARM is not supported yet.
+    # On x86_64 lldb-dap seems to ignore targetId when stepping into functions.
----------------
kendalharland wrote:

Ah thanks for catching that. I added back the original `@skipIf` since the comment indicates that running the test on ARM is a waste, given that InstructionControlFlowKind is unsupported, and combined that with the `@expectedFailureAll` you gave above to expect failure on Windows configurations.

https://github.com/llvm/llvm-project/pull/96687


More information about the lldb-commits mailing list