[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Mon Jul 15 02:29:36 PDT 2024
================
@@ -10,9 +10,10 @@
class TestDAP_stepInTargets(lldbdap_testcase.DAPTestCaseBase):
- @skipIf(
- archs=no_match(["x86_64"])
- ) # InstructionControlFlowKind for ARM is not supported yet.
+ @skipIf
+ # InstructionControlFlowKind for ARM is not supported yet.
+ # On x86_64 lldb-dap seems to ignore targetId when stepping into functions.
----------------
labath wrote:
Judging by everything said on this thread, I believe this is only true on x86_64 *windows*, so we should limit the exclusion to windows. Then you may actually be able to keep the xfail decorator, since the test is really expected to fail in this configuration (until the issue is fixed). (i.e., I think this should use `@expectedFailureAll(oslist=["windows"])` instead of the `@skipIf`).
https://github.com/llvm/llvm-project/pull/96687
More information about the lldb-commits
mailing list