[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 12 10:39:16 PDT 2024


jimingham wrote:

That was actually from a debugging session using the test.  I got rid of all the other evidence of that experiment in the test case, but missed this one.

Jim


> On Jul 12, 2024, at 10:34 AM, Alex Langford ***@***.***> wrote:
> 
> 
> @bulbazord commented on this pull request.
> 
> In lldb/test/API/python_api/event/TestEvents.py <https://github.com/llvm/llvm-project/pull/98571#discussion_r1676240655>:
> 
> > @@ -443,11 +474,17 @@ def test_shadow_listener(self):
>          # Put in a counter to make sure we don't spin forever if there is some
>          # error in the logic.
>          counter = 0
> +        run_wo_stop = False
> Doesn't look like this is used? Maybe a holdover from a previous implementation?
> 
>> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/98571#pullrequestreview-2175403620>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW62L4ZE2XTGU4J7LETZMAHSZAVCNFSM6AAAAABKX7JI4OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZVGQYDGNRSGA>.
> You are receiving this because you authored the thread.
> 



https://github.com/llvm/llvm-project/pull/98571


More information about the lldb-commits mailing list