[Lldb-commits] [lldb] c471d36 - [lldb][test] Narrow enum test xfail to clang < 19.0 (#98616)

[via lldb-commits]

Author: David Spickett
Date: 2024-07-12T13:12:35+01:00
New Revision: c471d3650aa3c6c1ddab64c029b7b89b12d18938

URL: https://github.com/llvm/llvm-project/commit/c471d3650aa3c6c1ddab64c029b7b89b12d18938
DIFF: https://github.com/llvm/llvm-project/commit/c471d3650aa3c6c1ddab64c029b7b89b12d18938.diff

LOG: [lldb][test] Narrow enum test xfail to clang < 19.0 (#98616)

Since #98335 clang adds DW_AT_type, unless strict DWARF is requested.

Added: 
    

Modified: 
    lldb/test/API/commands/expression/bitfield_enums/TestBitfieldEnums.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/expression/bitfield_enums/TestBitfieldEnums.py b/lldb/test/API/commands/expression/bitfield_enums/TestBitfieldEnums.py
index dbe9b9241a9ac..05db4075870b8 100644
--- a/lldb/test/API/commands/expression/bitfield_enums/TestBitfieldEnums.py
+++ b/lldb/test/API/commands/expression/bitfield_enums/TestBitfieldEnums.py
@@ -10,9 +10,11 @@
 
 
 class TestBitfieldEnum(TestBase):
-    # clang's DWARF v2 output is missing DW_AT_type which causes unsigned_max to
-    # appear as -1 instead of the "max" enumerator, whose value is 3.
-    @skipIf(dwarf_version=["<", "3"], compiler="clang")
+    # Prior to clang-19, clang's DWARF v2 is missing missing DW_AT_type which
+    # causes unsigned_max to appear as -1 instead of the "max" enumerator, whose
+    # value is 3. From 19 onward, DW_AT_type is added as long as strict DWARF
+    # is not enabled.
+    @skipIf(dwarf_version=["<", "3"], compiler="clang", compiler_version=["<", "19.0"])
     def test_bitfield_enums(self):
         self.build()