[Lldb-commits] [lldb] [lldb][test] Narrow enum test xfail to clang < 19.0 (PR #98616)
via lldb-commits
lldb-commits at lists.llvm.org
Fri Jul 12 03:47:04 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
<details>
<summary>Changes</summary>
Since #<!-- -->98335 clang adds DW_AT_type, unless strict DWARF is requested.
---
Full diff: https://github.com/llvm/llvm-project/pull/98616.diff
1 Files Affected:
- (modified) lldb/test/API/commands/expression/bitfield_enums/TestBitfieldEnums.py (+5-3)
``````````diff
diff --git a/lldb/test/API/commands/expression/bitfield_enums/TestBitfieldEnums.py b/lldb/test/API/commands/expression/bitfield_enums/TestBitfieldEnums.py
index dbe9b9241a9ac..05db4075870b8 100644
--- a/lldb/test/API/commands/expression/bitfield_enums/TestBitfieldEnums.py
+++ b/lldb/test/API/commands/expression/bitfield_enums/TestBitfieldEnums.py
@@ -10,9 +10,11 @@
class TestBitfieldEnum(TestBase):
- # clang's DWARF v2 output is missing DW_AT_type which causes unsigned_max to
- # appear as -1 instead of the "max" enumerator, whose value is 3.
- @skipIf(dwarf_version=["<", "3"], compiler="clang")
+ # Prior to clang-19, clang's DWARF v2 is missing missing DW_AT_type which
+ # causes unsigned_max to appear as -1 instead of the "max" enumerator, whose
+ # value is 3. From 19 onward, DW_AT_type is added as long as strict DWARF
+ # is not enabled.
+ @skipIf(dwarf_version=["<", "3"], compiler="clang", compiler_version=["<", "19.0"])
def test_bitfield_enums(self):
self.build()
``````````
</details>
https://github.com/llvm/llvm-project/pull/98616
More information about the lldb-commits
mailing list