[Lldb-commits] [lldb] [lldb] Fix ThreadList assignment race (PR #98293)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 11 05:02:38 PDT 2024


labath wrote:

> LGTM.
> 
> As a nice to have, maybe add a short explanation to the first mutex explaining that these operations are only allowed between thread lists belonging to the same process. Your current comment makes it sound as if that only applies _if_ the processes are the same, but per the assertion, the requirement is stricter than that.
> 
> EDIT: Oh I see you had the comment in the header. That covers my concern, though I'd still add the same thing to the assert to quickly diagnose the issue if someone were to hit it.

Elaborated the assert comment as well.

https://github.com/llvm/llvm-project/pull/98293


More information about the lldb-commits mailing list