[Lldb-commits] [lldb] [lldb][DataFormatter] Clean up LibcxxStdMapSyntheticFrontEnd::GetKeyValuePair (PR #97551)

[Michael Buch via lldb-commits]

Michael137 wrote:

> Why do we even have the `GetValueOffset` function? Wouldn't it be possible to dredge the actual type describing the node layout from somewhere (a template argument of something, or a return value of some method?)

Agreed? that’s actually what I’m planning to do in https://github.com/llvm/llvm-project/pull/97579 (by getting the type via a typedef). This patch was kind of an intermediate step to make the followup more straightforward to review, but now looking at it, I’m not sure there’s value in that. I guess we could just skip this and do the refactor in one go

https://github.com/llvm/llvm-project/pull/97551