[Lldb-commits] [lldb] [lldb/Interpreter] Discard ScriptedThreadPlan::GetStopDescription return value (PR #96985)

[Nico Weber via lldb-commits]

================
@@ -106,10 +106,13 @@ ScriptInterpreter::GetOpaqueTypeFromSBEvent(const lldb::SBEvent &event) const {
   return event.m_opaque_ptr;
 }
 
-Stream *ScriptInterpreter::GetOpaqueTypeFromSBStream(
+lldb::StreamSP ScriptInterpreter::GetOpaqueTypeFromSBStream(
     const lldb::SBStream &stream) const {
-  if (stream.m_opaque_up)
-    return const_cast<lldb::SBStream &>(stream).m_opaque_up.get();
+  if (stream.m_opaque_up) {
+    lldb::StreamSP s = std::make_shared<lldb_private::StreamString>();
+    *s << const_cast<lldb::SBStream &>(stream).GetData();
----------------
nico wrote:

Chances are it also breaks building on Windows, where /OPT:REF might not be strong enough to remove this.

Also, we do have a `LLVM_NO_DEAD_STRIP` option, which presumably no longer builds after this change either.

https://github.com/llvm/llvm-project/pull/96985