[Lldb-commits] [lldb] [lldb/DWARF] Don't start class definitions in ParseStructureLikeDIE (PR #96755)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 27 08:00:07 PDT 2024


labath wrote:

> This is a really nice cleanup! It actually aligns almost exactly with [our in-progress version of this](https://github.com/llvm/llvm-project/blob/caacb57a46f34bf663fa5ab2190b361ce29b255b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp).
> 
> LGTM
> 
> Agree with your point about `PrepareContextToReceiveMembers`. We can add those as needed. In our version of this I had to only add it in `ParseSubroutine`, as you've also effectively done.

Thanks. It's very nice when things fit together.

https://github.com/llvm/llvm-project/pull/96755


More information about the lldb-commits mailing list