[Lldb-commits] [lldb] [lldb] Don't call AddRemoteRegisters if the target XML did not include any registers (PR #96907)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 27 07:57:49 PDT 2024


================
@@ -4879,7 +4879,9 @@ bool ProcessGDBRemote::GetGDBServerRegisterInfo(ArchSpec &arch_to_use) {
   m_registers_enum_types.clear();
   std::vector<DynamicRegisterInfo::Register> registers;
   if (GetGDBServerRegisterInfoXMLAndProcess(arch_to_use, "target.xml",
-                                            registers))
+                                            registers) &&
+      // Target XML is not required to include register information.
+      (!registers.empty()))
----------------
DavidSpickett wrote:

Just paranoia :) I've removed them.

https://github.com/llvm/llvm-project/pull/96907


More information about the lldb-commits mailing list