[Lldb-commits] [lldb] [lldb] Fix string truncation method when substring is the prefix of string (NFC) (PR #94785)

[David Spickett via lldb-commits]

================
@@ -287,7 +287,7 @@ Status PlatformAndroid::DownloadModuleSlice(const FileSpec &src_file_spec,
   static constexpr llvm::StringLiteral k_zip_separator("!/");
   size_t pos = source_file.find(k_zip_separator);
   if (pos != std::string::npos)
-    source_file = source_file.substr(0, pos);
+    source_file = source_file.resize(0, pos);
----------------
DavidSpickett wrote:

According to https://en.cppreference.com/w/cpp/string/basic_string/resize, `resize(pos)` would be correct here. Otherwise we're resizing to 0 characters.

https://github.com/llvm/llvm-project/pull/94785