[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)
via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 25 12:33:00 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: Kendal Harland (kendalharland)
<details>
<summary>Changes</summary>
The strings this test is using seem to consistently fail to match against the expected values when built & run targeting Windows amd64. This PR updates them to the expected values.
---
Full diff: https://github.com/llvm/llvm-project/pull/96687.diff
1 Files Affected:
- (modified) lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py (+4-4)
``````````diff
diff --git a/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py b/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py
index 6296f6554d07e..cc53954885cdf 100644
--- a/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py
+++ b/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py
@@ -55,14 +55,14 @@ def test_basic(self):
self.assertEqual(len(step_in_targets), 3, "expect 3 step in targets")
# Verify the target names are correct.
- self.assertEqual(step_in_targets[0]["label"], "bar()", "expect bar()")
- self.assertEqual(step_in_targets[1]["label"], "bar2()", "expect bar2()")
+ self.assertEqual(step_in_targets[0]["label"], "int bar2(void)", "expect bar2()")
+ self.assertEqual(step_in_targets[1]["label"], "int bar(void)", "expect bar()")
self.assertEqual(
- step_in_targets[2]["label"], "foo(int, int)", "expect foo(int, int)"
+ step_in_targets[2]["label"], "int foo(int, int)", "expect foo(int, int)"
)
# Choose to step into second target and verify that we are in bar2()
self.stepIn(threadId=tid, targetId=step_in_targets[1]["id"], waitForStop=True)
leaf_frame = self.dap_server.get_stackFrame()
self.assertIsNotNone(leaf_frame, "expect a leaf frame")
- self.assertEqual(leaf_frame["name"], "bar2()")
+ self.assertEqual(leaf_frame["name"], "int bar2(void)")
``````````
</details>
https://github.com/llvm/llvm-project/pull/96687
More information about the lldb-commits
mailing list