[Lldb-commits] [lldb] [lldb][test] Set target OS for API tests in case of remote testing (PR #96654)
Alex Langford via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 25 10:32:37 PDT 2024
================
@@ -97,6 +101,9 @@ def finalize_build_dictionary(dictionary):
dictionary = {}
dictionary["OS"] = "Android"
dictionary["PIE"] = 1
+ elif target_is_remote_linux():
+ dictionary = dictionary or {}
----------------
bulbazord wrote:
Suggestion: Pull the dictionary checking-logic out of these blocks and put it at the top of the function:
```
def finalize_build_dictionary(dictionary):
if dictionary is None:
dictionary = {}
if target_is_android():
# ...
````
https://github.com/llvm/llvm-project/pull/96654
More information about the lldb-commits
mailing list