[Lldb-commits] [lldb] [lldb] Support new libc++ __compressed_pair layout (PR #96538)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r 62baf21daa377c4ec1a641b26931063c1117d262...3b4d9629a68c9e75dfd139ee2745bf00db979ecd lldb/examples/synthetic/libcxx.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/TestDataFormatterLibcxxUniquePtr.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- examples/synthetic/libcxx.py	2024-06-24 19:22:02.000000 +0000
+++ examples/synthetic/libcxx.py	2024-06-24 19:26:18.844345 +0000
@@ -762,11 +762,13 @@
             if has_compressed_pair_layout:
                 map_endcap = self._get_value_of_compressed_pair(
                     map_.GetChildMemberWithName("__end_cap_")
                 )
             else:
-                map_endcap = map_.GetChildMemberWithName("__end_cap_").GetValueAsUnsigned(0)
+                map_endcap = map_.GetChildMemberWithName(
+                    "__end_cap_"
+                ).GetValueAsUnsigned(0)
 
             # check consistency
             if not map_first <= map_begin <= map_end <= map_endcap:
                 logger.write("map pointers are not monotonic")
                 return
--- test/API/functionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py	2024-06-24 19:22:02.000000 +0000
+++ test/API/functionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py	2024-06-24 19:26:18.939102 +0000
@@ -60,12 +60,12 @@
         self.runCmd("type format add -f hex int")
 
         self.expect(
             "frame variable numbers_list --raw",
             matching=False,
-            #substrs=["size=0", "{}"], # TODO: if __padding_ members aren't added this isn't needed
-            substrs=["size=0"]
+            # substrs=["size=0", "{}"], # TODO: if __padding_ members aren't added this isn't needed
+            substrs=["size=0"],
         )
 
         if stdlib_type == USE_LIBSTDCPP:
             self.expect(
                 "frame variable &numbers_list._M_impl._M_node --raw",
--- test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/TestDataFormatterLibcxxUniquePtr.py	2024-06-24 19:22:02.000000 +0000
+++ test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/TestDataFormatterLibcxxUniquePtr.py	2024-06-24 19:26:18.994855 +0000
@@ -43,11 +43,11 @@
 
         valobj = self.expect_var_path(
             "up_empty",
             type=self.make_expected_type("int"),
             summary="nullptr",
-            #children=[ValueCheck(name="pointer"), ValueCheck(name="deleter")], # TODO: shouldn't be printing deleter
+            # children=[ValueCheck(name="pointer"), ValueCheck(name="deleter")], # TODO: shouldn't be printing deleter
             children=[ValueCheck(name="pointer")],
         )
         self.assertEqual(
             valobj.child[0].GetValueAsUnsigned(lldb.LLDB_INVALID_ADDRESS), 0
         )
@@ -58,38 +58,38 @@
 
         valobj = self.expect_var_path(
             "up_int",
             type=self.make_expected_type("int"),
             summary="10",
-            #children=[ValueCheck(name="pointer"), ValueCheck(name="deleter")], # TODO: shouldn't be printing deleter
+            # children=[ValueCheck(name="pointer"), ValueCheck(name="deleter")], # TODO: shouldn't be printing deleter
             children=[ValueCheck(name="pointer")],
         )
         self.assertNotEqual(valobj.child[0].unsigned, 0)
 
         valobj = self.expect_var_path(
             "up_int_ref",
             type=self.make_expected_type("int", qualifiers="&"),
             summary="10",
-            #children=[ValueCheck(name="pointer"), ValueCheck(name="deleter")], # TODO: shouldn't be printing deleter
+            # children=[ValueCheck(name="pointer"), ValueCheck(name="deleter")], # TODO: shouldn't be printing deleter
             children=[ValueCheck(name="pointer")],
         )
         self.assertNotEqual(valobj.child[0].unsigned, 0)
 
         valobj = self.expect_var_path(
             "up_int_ref_ref",
             type=self.make_expected_type("int", qualifiers="&&"),
             summary="10",
-            #children=[ValueCheck(name="pointer"), ValueCheck(name="deleter")], # TODO: shouldn't be printing deleter
+            # children=[ValueCheck(name="pointer"), ValueCheck(name="deleter")], # TODO: shouldn't be printing deleter
             children=[ValueCheck(name="pointer")],
         )
         self.assertNotEqual(valobj.child[0].unsigned, 0)
 
         valobj = self.expect_var_path(
             "up_str",
             type=self.make_expected_basic_string_ptr(),
             summary='"hello"',
-            #children=[ValueCheck(name="pointer"), ValueCheck(name="deleter")], # TODO: shouldn't be printing deleter
+            # children=[ValueCheck(name="pointer"), ValueCheck(name="deleter")], # TODO: shouldn't be printing deleter
             children=[ValueCheck(name="pointer")],
         )
 
         valobj = self.expect_var_path("up_user", type=self.make_expected_type("User"))
         self.assertRegex(valobj.summary, "^User @ 0x0*[1-9a-f][0-9a-f]+$")

``````````

</details>


https://github.com/llvm/llvm-project/pull/96538