[Lldb-commits] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [Memprof] Adds the option to collect AccessCountHistograms for memprof. (PR #94264)

Teresa Johnson via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 21 15:27:15 PDT 2024


================
@@ -610,13 +670,33 @@ RawMemProfReader::peekBuildIds(MemoryBuffer *DataBuffer) {
   return BuildIds.takeVector();
 }
 
+// FIXME: Add a schema for serializing similiar to IndexedMemprofReader. This
+// will help being able to deserialize different versions raw memprof versions
+// more easily.
+llvm::SmallVector<std::pair<uint64_t, MemInfoBlock>>
+RawMemProfReader::readMemInfoBlocks(const char *Ptr) {
+  if (MemprofRawVersion == 3ULL) {
+    errs() << "Reading V3\n";
----------------
teresajohnson wrote:

Once you do that, the braces can be removed from all of the if else conditions here which have single statement bodies

https://github.com/llvm/llvm-project/pull/94264


More information about the lldb-commits mailing list