[Lldb-commits] [lldb] [lldb] Parse and display register field enums (PR #95768)

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 20 14:44:52 PDT 2024


================
@@ -4254,14 +4356,55 @@ static std::vector<RegisterFlags::Field> ParseFlagsFields(XMLNode flags_node,
     });
 
     if (name && start && end) {
-      if (*start > *end) {
+      if (*start > *end)
         LLDB_LOG(
             log,
             "ProcessGDBRemote::ParseFlagsFields Start {0} > end {1} in field "
             "\"{2}\", ignoring",
             *start, *end, name->data());
-      } else {
-        fields.push_back(RegisterFlags::Field(name->str(), *start, *end));
+      else {
+        if (RegisterFlags::Field::GetSizeInBits(*start, *end) > 64)
+          LLDB_LOG(log,
+                   "ProcessGDBRemote::ParseFlagsFields Ignoring field \"{2}\" "
+                   "that has "
+                   " size > 64 bits, this is not supported",
----------------
jasonmolenda wrote:

there's a whitespace at the end of `"that has "`, we don't need one at the start.

https://github.com/llvm/llvm-project/pull/95768


More information about the lldb-commits mailing list