[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)
Vladislav Dzhidzhoev via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 20 04:34:45 PDT 2024
dzhidzhoev wrote:
> Can't say I'm excited to see this feature (although I admit it is looking less daunting than I originally feared). Can you explain why you need this feature? Is there some particular aspect of lldb's remote operation that you think isn't well covered by the existing tests? Is there a particular category of tests that you'd like to have more than others? How many of the existing tests would exercise the remote platform capability in a meaningful way (a lot of these tests don't even build runnable binaries)?
I'm sorry, it took a bit longer time to answer than I expected, my apologies.
In general, our goal is to maximize the functionality of the testing toolkit in case of cross-compilation+remote launch setup.
I agree that not every Shell test launches binaries. According to my grep-based statistics, it's roughly one-fifth of the tests currently (117/533 test files that contain "r", "run", or "process launch" commands). Though it's still a number.
Also, launching the "platform select" and "platform connect ..." commands before executing the rest of a Shell test script may be useful. Here is an example case of a potentially unexpected behavior https://github.com/llvm/llvm-project/pull/94165. So it's not always necessary to have a Shell test build and run a binary to reveal some nuances.
And it seems to me, that it won't cause excessive maintenance overhead since we essentially add just two extra commands to %lldb invocation.
I haven't opened an RFC since I thought it would be clearer to discuss that idea with the showcase of implementation. I'm open to moving a discussion there if it's considered as a better approach in this case (please let me know😅).
https://github.com/llvm/llvm-project/pull/95986
More information about the lldb-commits
mailing list