[Lldb-commits] [lldb] Convert ValueObject::Dump() to return llvm::Error() (NFCish) (PR #95857)

[David Spickett via lldb-commits]

================
@@ -1233,7 +1233,10 @@ bool SBValue::GetDescription(SBStream &description) {
     DumpValueObjectOptions options;
     options.SetUseDynamicType(m_opaque_sp->GetUseDynamic());
     options.SetUseSyntheticValue(m_opaque_sp->GetUseSynthetic());
-    value_sp->Dump(strm, options);
+    if (llvm::Error error = value_sp->Dump(strm, options)) {
+      strm << "error: " << toString(std::move(error));
+      return false;
----------------
DavidSpickett wrote:

The docs are non-existent, but just from the prototype I'd assume it can return false already: https://lldb.llvm.org/python_api/lldb.SBValue.html#lldb.SBValue.GetDescription

So it might break someone's existing script but not in a totally unexpected way. I'd lean toward this being a bug fix.

https://github.com/llvm/llvm-project/pull/95857