[Lldb-commits] [lldb] [LLDB] Remove the redundent increment of 'properties' variable (PR #95675)
Alex Langford via lldb-commits
lldb-commits at lists.llvm.org
Mon Jun 17 10:49:09 PDT 2024
https://github.com/bulbazord requested changes to this pull request.
I think you can probably just remove the check for `properties` value entirely. This is the first property that may be printed, so it will never be greater than 0. I think this will work:
```
stream.Printf(" ( arch=");
```
The other ones will have to stay because if the target architecture isn't valid, properties may still be 0.
Alternatively, if you feel motivated, you can rewrite the target dumping code altogether. My suggestion would be to gather all of the information up front (triple, platform, pid, state, etc) and then print it all at the end in one group so we don't have to do all these inline ternary conditions in the first place.
https://github.com/llvm/llvm-project/pull/95675
More information about the lldb-commits
mailing list