[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 17 09:15:38 PDT 2024


================
@@ -858,10 +923,224 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
   return error;
 }
 
-size_t MinidumpFileBuilder::GetDirectoriesNum() const {
-  return m_directories.size();
+Status MinidumpFileBuilder::AddMemoryList_32(
+    const Process::CoreFileMemoryRanges &ranges) {
+  std::vector<MemoryDescriptor> descriptors;
+  Status error;
+  Log *log = GetLog(LLDBLog::Object);
+  size_t region_index = 0;
----------------
Jlalond wrote:

Done. Albeit the `m_data` buffer that the class uses does get used and then reallocated when we call `Clear()` in flush to disk. May want to look into keeping a write index and a range...

https://github.com/llvm/llvm-project/pull/95312


More information about the lldb-commits mailing list