[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 13 09:56:22 PDT 2024


================
@@ -40,7 +46,7 @@ lldb_private::Status WriteString(const std::string &to_write,
 /// the data on heap.
 class MinidumpFileBuilder {
 public:
-  MinidumpFileBuilder() = default;
+  MinidumpFileBuilder(lldb::FileUP&& core_file): m_core_file(std::move(core_file)) {};
----------------
Jlalond wrote:

I agree with this. I also think it reduces the split responsibility with `ObjectfileMinidump`

https://github.com/llvm/llvm-project/pull/95312


More information about the lldb-commits mailing list