[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 12 21:43:51 PDT 2024


================
@@ -59,39 +68,67 @@ class MinidumpFileBuilder {
   // Add ThreadList stream, containing information about all threads running
   // at the moment of core saving. Contains information about thread
   // contexts.
-  lldb_private::Status AddThreadList(const lldb::ProcessSP &process_sp);
-  // Add Exception streams for any threads that stopped with exceptions.
-  void AddExceptions(const lldb::ProcessSP &process_sp);
----------------
clayborg wrote:

These haven't changed at all, so I would move them back to this line. No need to make changes to this header file if things haven't changed (`AddThreadList` and `AddExceptions`). So make as much of this the same as it was before by reverting the above 3 lines and removing them from below.

https://github.com/llvm/llvm-project/pull/95312


More information about the lldb-commits mailing list