[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

[Greg Clayton via lldb-commits]

================
@@ -40,7 +46,7 @@ lldb_private::Status WriteString(const std::string &to_write,
 /// the data on heap.
 class MinidumpFileBuilder {
 public:
-  MinidumpFileBuilder() = default;
+  MinidumpFileBuilder(lldb::FileUP&& core_file): m_core_file(std::move(core_file)) {};
----------------
clayborg wrote:

We should a `const lldb::ProcessSP &process_sp` to the constructor and remove all `const lldb::ProcessSP &process_sp` arguemnts from the methods below. We never want to change processes while creating a minidump. We should store the process shared pointer as an instance variable and then the methods that used to take the `const lldb::ProcessSP &process_sp` as an argument now use the instance variable:
```
  lldb::ProcessSP m_process_sp;
```

https://github.com/llvm/llvm-project/pull/95312