[Lldb-commits] [lldb] [lldb][DWARFASTParser][NFC] Factor out CXX/ObjC method specifics out of ParseSubroutine (PR #95078)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 11 00:23:39 PDT 2024


================
@@ -370,6 +371,20 @@ class DWARFASTParserClang : public lldb_private::plugin::dwarf::DWARFASTParser {
                          ParsedDWARFTypeAttributes &attrs);
   lldb::TypeSP ParseSubroutine(const lldb_private::plugin::dwarf::DWARFDIE &die,
                                const ParsedDWARFTypeAttributes &attrs);
+
+  bool
+  HandleObjCMethod(lldb_private::ObjCLanguage::MethodName const &objc_method,
+                   lldb_private::plugin::dwarf::DWARFDIE const &die,
+                   lldb_private::CompilerType clang_type,
+                   ParsedDWARFTypeAttributes const &attrs, bool is_variadic);
+
+  std::pair<bool, lldb::TypeSP>
+  HandleCXXMethod(lldb_private::plugin::dwarf::DWARFDIE const &die,
----------------
Michael137 wrote:

The names `HandleCXXMethod` and `HandleObjCMethod` feel a bit generic. Possibly something like `LinkCXXMethodDeclContextToDIE` would be better?

https://github.com/llvm/llvm-project/pull/95078


More information about the lldb-commits mailing list