[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #94575)

[Alex Langford via lldb-commits]

================
@@ -1821,31 +1856,24 @@ def SymbolicateCrashLogs(debugger, command_args, result, is_command):
         print(debugger.GetVersionString())
         return
 
-    if options.debug:
-        print("command_args = %s" % command_args)
-        print("options", options)
-        print("args", options.reports)
-
     if options.debug_delay > 0:
         print("Waiting %u seconds for debugger to attach..." % options.debug_delay)
         time.sleep(options.debug_delay)
     error = lldb.SBError()
 
     def should_run_in_interactive_mode(options, ci):
-        if options.interactive:
+        if options.mode == CrashLogLoadingMode.interactive:
----------------
bulbazord wrote:

I guess I'm somewhat confused by the purpose of this function... The only way `options.mode` is ever not interactive is if it's explicitly set by the user to be something else right? Why might we want to ignore that?

https://github.com/llvm/llvm-project/pull/94575