[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #94575)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 10 15:23:41 PDT 2024


================
@@ -1794,8 +1802,35 @@ def SymbolicateCrashLogs(debugger, command_args, result, is_command):
         result.SetError(str(e))
         return
 
+    # To avoid breaking existing users, we should keep supporting legacy flags
+    # even if we don't use them / advertise them anymore.
+    if not options.mode:
+        if options.batch:
+            options.mode = CrashLogLoadingMode.batch
+        else:
+            options.mode = CrashLogLoadingMode.interactive
----------------
bulbazord wrote:

Can you detect both `options.batch` and `options.interactive` being specified at the same time? I assume whichever is listed first will get selected... but I would assume we'd want to add something that prevents you from choosing both.

https://github.com/llvm/llvm-project/pull/94575


More information about the lldb-commits mailing list