[Lldb-commits] [lldb] [lldb][API] Add Find(Ranges)InMemory() to Process SB API (PR #95007)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 10 10:29:00 PDT 2024


================
@@ -810,6 +809,112 @@ const char *SBProcess::GetBroadcasterClass() {
   return ConstString(Process::GetStaticBroadcasterClass()).AsCString();
 }
 
+lldb::SBAddressRangeList
+SBProcess::FindRangesInMemory(const void *buf, uint64_t size,
+                              SBAddressRangeList &ranges, uint32_t alignment,
+                              uint32_t max_matches) {
----------------
clayborg wrote:

I didn't realize how many error conditions that can go wrong here, and logging isn't the place to do that, so we should probably add a `SBError &error` argument to the end here and report the error back to the user:
```
lldb::SBAddressRangeList
SBProcess::FindRangesInMemory(const void *buf, uint64_t size,
                              SBAddressRangeList &ranges, uint32_t alignment,
                              uint32_t max_matches, SBError &error) {
```

https://github.com/llvm/llvm-project/pull/95007


More information about the lldb-commits mailing list