[Lldb-commits] [lldb] [lldb] Fix TestModuleLoadedNotifys API test to work correctly on most of Linux targets (PR #94672)
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Mon Jun 10 01:41:22 PDT 2024
================
@@ -118,6 +118,6 @@ def test_launch_notifications(self):
# On Linux we get events for ld.so, [vdso], the binary and then all libraries.
avg_solibs_added_per_event = round(
- float(total_solibs_added) / float(total_modules_added_events)
+ 10.0 * float(total_solibs_added) / float(total_modules_added_events)
----------------
labath wrote:
> > You can't really call it "number of libraries per event" anymore if you multiply by ten.
>
> I have updated the patch.
>
> > Maybe you could just remove the round call, and compare to 1.0
>
> No, because assertGreater() expects int parameters.
That's strange because `assertGreater(47.0001, 47.0000)` works just fine for me. So does `assertLessEqual(set(["a", "b"]), set(["a", "b"]))`.
Could it be that you're still running on the version of lldb that has the ancient checked in copy of `unittest`?
https://github.com/llvm/llvm-project/pull/94672
More information about the lldb-commits
mailing list