[Lldb-commits] [lldb] a2bcb93 - [lldb] Attempt to fix TestCompletion on macos

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu May 30 08:40:35 PDT 2024


Author: Pavel Labath
Date: 2024-05-30T15:28:13Z
New Revision: a2bcb932f3130c3c18ceb06872da9002f6845c4b

URL: https://github.com/llvm/llvm-project/commit/a2bcb932f3130c3c18ceb06872da9002f6845c4b
DIFF: https://github.com/llvm/llvm-project/commit/a2bcb932f3130c3c18ceb06872da9002f6845c4b.diff

LOG: [lldb] Attempt to fix TestCompletion on macos

Macos will automatically load dependent modules when creating a target,
resulting in more modules than the test expects.

Added: 
    

Modified: 
    lldb/test/API/functionalities/completion/TestCompletion.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/completion/TestCompletion.py b/lldb/test/API/functionalities/completion/TestCompletion.py
index 24a8e001fee38..d304e12a80c2d 100644
--- a/lldb/test/API/functionalities/completion/TestCompletion.py
+++ b/lldb/test/API/functionalities/completion/TestCompletion.py
@@ -909,8 +909,10 @@ def test_ambiguous_subcommand(self):
 
     def test_shlib_name(self):
         self.build()
-        target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
-        self.assertTrue(target, VALID_TARGET)
+        error = lldb.SBError()
+        # Create a target, but don't load dependent modules
+        target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"), None, None, False, error)
+        self.assertSuccess(error)
         self.registerSharedLibrariesWithTarget(target, ["shared"])
 
         basenames = []


        


More information about the lldb-commits mailing list