[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

[Santhosh Kumar Ellendula via lldb-commits]

================
@@ -348,6 +348,17 @@
                 "type": "string",
                 "description": "The time in seconds to wait for a program to stop when attaching using \"attachCommands\". Defaults to 30 seconds."
               },
+              "port": {
+                "type": [
+                  "number",
+                  "string"
+                ],
+                "description": "TCP/IP port to attach to. Specifying both pid and port is an error."
+              },
----------------
santhoshe447 wrote:

Thank you for the suggestion. I think labeling it as "gdb-remote-port" & "gdb-remote-hostname" makes sense for clarity. Since there are no other process plugins that support connecting via port, this lable will also help users understand its purpose more easily.
We used the attribute names "port" and "hostname" because Microsoft visual studio Code IDE examples use the same terminology (https://code.visualstudio.com/Docs/editor/debugging#_launch-configurations). Please reconsider this suggestion to ensure consistency with widely accepted convention.


![image](https://github.com/llvm/llvm-project/assets/150406203/409b9b42-64fc-46c4-a152-94b3357f0488)


https://github.com/llvm/llvm-project/pull/91570