[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

[Michael Buch via lldb-commits]

Michael137 wrote:

Looks like this is breaking the macOS CI: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/2534/execution/node/97/log
```
======================================================================
FAIL: test_shlib_name (TestCompletion.CommandLineCompletionTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake/llvm-project/lldb/test/API/functionalities/completion/TestCompletion.py", line 926, in test_shlib_name
    self.completions_match("target symbols add -s ", basenames + paths)
  File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2219, in completions_match
    self.assertCountEqual(
AssertionError: Element counts were not equal:
First has 1, Second has 0:  'dyld'
First has 2, Second has 1:  'libc++.1.dylib'
First has 1, Second has 0:  '/usr/lib/dyld' : List of returned completion is wrong
Config=x86_64-/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake/lldb-build/bin/clang
======================================================================
FAIL: test_shlib_name (TestCompletion.CommandLineCompletionTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2017, in tearDown
    Base.tearDown(self)
  File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1132, in tearDown
    self.assertEqual(lldb.SBModule.GetNumberAllocatedModules(), 0)
AssertionError: 1 != 0
Config=x86_64-/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake/lldb-build/bin/clang
----------------------------------------------------------------------
Ran 86 tests in 37.855s

FAILED (failures=2, skipped=1)
```

Mind taking a look @labath ?

https://github.com/llvm/llvm-project/pull/93458