[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

Felipe de Azevedo Piovezan via lldb-commits lldb-commits at lists.llvm.org
Wed May 29 08:22:36 PDT 2024


felipepiovezan wrote:

> > Discussed with Pavel, I applied this change to #92328 so we can ensure the DIEs from the index is always definition DIEs and avoid duplicate/expensive checks later.
> 
> To elaborate, I suggested Zequan does this, because I think there's consensus that this is a good way to filter out (incorrect) declaration dies from the index, and it's a better (faster) fix than what Zequan had in his PR. It's still worthwhile to figure out where those entries are coming from. We know of one case with type units and that has now been fixed (thanks to David), if there are more, we should try to understand where they are coming from).

Sounds good! 

https://github.com/llvm/llvm-project/pull/91808


More information about the lldb-commits mailing list