[Lldb-commits] [lldb] 0380044 - Fix the EditLine unittest build on Darwin after PR 92865

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Tue May 28 17:49:32 PDT 2024


Author: Jim Ingham
Date: 2024-05-28T17:47:08-07:00
New Revision: 0380044e16a1c016e001a56c0ca7f4db649a6cae

URL: https://github.com/llvm/llvm-project/commit/0380044e16a1c016e001a56c0ca7f4db649a6cae
DIFF: https://github.com/llvm/llvm-project/commit/0380044e16a1c016e001a56c0ca7f4db649a6cae.diff

LOG: Fix the EditLine unittest build on Darwin after PR 92865

There was a Darwin only use of setupterm (under USE_SETUPTERM_WORKAROUND)
that required libcurses.dylib.  That was added to the main build, but
not to the unittest.

Added: 
    

Modified: 
    lldb/unittests/CMakeLists.txt
    lldb/unittests/Editline/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/CMakeLists.txt b/lldb/unittests/CMakeLists.txt
index a2585a94b6155..728dec5006d6b 100644
--- a/lldb/unittests/CMakeLists.txt
+++ b/lldb/unittests/CMakeLists.txt
@@ -51,11 +51,13 @@ if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows")
   # FIXME: APITests.exe is not a valid googletest binary.
   add_subdirectory(API)
 endif()
+if (NOT CMAKE_SYSTEM_NAME MATCHES "Darwin" OR LLDB_ENABLE_CURSES)
+  add_subdirectory(Editline)
+endif()
 add_subdirectory(Breakpoint)
 add_subdirectory(Core)
 add_subdirectory(DataFormatter)
 add_subdirectory(Disassembler)
-add_subdirectory(Editline)
 add_subdirectory(Expression)
 add_subdirectory(Host)
 add_subdirectory(Interpreter)

diff  --git a/lldb/unittests/Editline/CMakeLists.txt b/lldb/unittests/Editline/CMakeLists.txt
index 4b2643d15c5fc..f213bfd1ab581 100644
--- a/lldb/unittests/Editline/CMakeLists.txt
+++ b/lldb/unittests/Editline/CMakeLists.txt
@@ -5,4 +5,5 @@ add_lldb_unittest(EditlineTests
     lldbHost
     lldbUtility
     LLVMTestingSupport
+    ${CURSES_LIBRARIES}
   )


        


More information about the lldb-commits mailing list