[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

Fri May 17 03:08:22 PDT 2024

labath wrote:

Thanks for checking this out.

> I just checked and I'm not seeing the hover's in the same format as they were when I made the pull request. The expression context should still have the expanded forms though for example:
> <img alt="Screenshot 2024-05-16 at 5 25 14 PM" width="467" src="https://private-user-images.githubusercontent.com/22535/331420652-28db4adc-d488-44ff-8d99-78966e0e0e05.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTU5NDA1NTEsIm5iZiI6MTcxNTk0MDI1MSwicGF0aCI6Ii8yMjUzNS8zMzE0MjA2NTItMjhkYjRhZGMtZDQ4OC00NGZmLThkOTktNzg5NjZlMGUwZTA1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTE3VDEwMDQxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZmMzA1YmZmMmI3NzBjNDgwNzI2OGIwZmMwYWNhYWMwMjQ1Mzg0MmJlMWViMzVjNjY0MGUzZDA3NDZjMzBiZjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.h5ENxzEWOpUxdFomZps6rWm7-J906W-3Le0mcRcYdUY">
> 

I see. I think it makes sense to show this expanded view in the debug console view. However, it does not appear to be useful for the hover view, and it's slowing things down significantly (for one particular probobuf variable, this increased the hover time from <1sec to ~6-7 seconds).

Would you be ok (both of you) with limiting the scope of this patch to the "repl" context?

https://github.com/llvm/llvm-project/pull/77026