[Lldb-commits] [lldb] [lldb] Fixed an invalid error message in the DAP disconnect response (PR #92345)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu May 16 03:05:04 PDT 2024


================
@@ -977,7 +977,7 @@ void request_disconnect(const llvm::json::Object &request) {
     g_dap.debugger.SetAsync(false);
     lldb::SBError error = terminateDebuggee ? process.Kill() : process.Detach();
     if (!error.Success())
-      response.try_emplace("error", error.GetCString());
+      response.try_emplace("error", std::string(error.GetCString()));
----------------
labath wrote:

`EmplaceSafeString` sounds like the right thing to use here.

https://github.com/llvm/llvm-project/pull/92345


More information about the lldb-commits mailing list