[Lldb-commits] [lldb] [lldb][Windows] Disable the TestGdbRemoteLibrariesSvr4Support test for Windows host (PR #92341)

Dmitry Vasilyev via lldb-commits lldb-commits at lists.llvm.org
Wed May 15 20:39:30 PDT 2024


https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/92341

Windows does not allow quotes in file names. So it is impossible to build `libsvr4lib_b".so` on Windows.

>From d1c9b46114621ca3c739b50a45d4aad9c20a2df1 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
Date: Thu, 16 May 2024 07:37:33 +0400
Subject: [PATCH] [lldb][Windows] Disable the TestGdbRemoteLibrariesSvr4Support
 test for Windows host

Windows does not allow quotes in file names. So it is impossible to build `libsvr4lib_b".so` on Windows.
---
 .../libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py         | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py b/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
index 846adade34402..02c9d318525fb 100644
--- a/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
+++ b/lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
@@ -4,6 +4,8 @@
 from lldbsuite.test.lldbtest import *
 
 
+# Windows does not allow quotes in file names.
+ at skipIf(hostoslist=["windows"])
 class TestGdbRemoteLibrariesSvr4Support(gdbremote_testcase.GdbRemoteTestCaseBase):
     FEATURE_NAME = "qXfer:libraries-svr4:read"
 



More information about the lldb-commits mailing list