[Lldb-commits] [lldb] [lldb] Fixed the TestFdLeak test (PR #92273)

Dmitry Vasilyev via lldb-commits lldb-commits at lists.llvm.org
Wed May 15 07:39:54 PDT 2024


https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/92273

Use `NUL` instead of `/dev/null` in case of the Windows host.

>From 6341c038d41ac3b533314568187b8d5d390dc861 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
Date: Wed, 15 May 2024 18:38:16 +0400
Subject: [PATCH] [lldb] Fixed the TestFdLeak test

Use `NUL` instead of `/dev/null` in case of the Windows host.
---
 lldb/test/API/functionalities/avoids-fd-leak/TestFdLeak.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lldb/test/API/functionalities/avoids-fd-leak/TestFdLeak.py b/lldb/test/API/functionalities/avoids-fd-leak/TestFdLeak.py
index e4f5cd3a03f86..e292885ec390d 100644
--- a/lldb/test/API/functionalities/avoids-fd-leak/TestFdLeak.py
+++ b/lldb/test/API/functionalities/avoids-fd-leak/TestFdLeak.py
@@ -26,7 +26,10 @@ def test_fd_leak_basic(self):
     @skipIfTargetAndroid()  # Android have some other file descriptors open by the shell
     @skipIfDarwinEmbedded  # <rdar://problem/33888742>  # debugserver on ios has an extra fd open on launch
     def test_fd_leak_log(self):
-        self.do_test(["log enable -f '/dev/null' lldb commands"])
+        if lldbplatformutil.getHostPlatform() == "windows":
+            self.do_test(["log enable -f 'NUL' lldb commands"])
+        else:
+            self.do_test(["log enable -f '/dev/null' lldb commands"])
 
     def do_test(self, commands):
         self.build()



More information about the lldb-commits mailing list