[Lldb-commits] [lldb] [lldb][Windows] Fixed the test gdb_remote_client/TestGDBRemotePlatformFile (PR #92088)

[Dmitry Vasilyev via lldb-commits]

https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/92088

>From 7dcfe773b6eef27aabbcc7fc68cd6448bc3c2e88 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
Date: Tue, 14 May 2024 13:08:35 +0400
Subject: [PATCH 1/2] [lldb][Windows] Fixed the test
 gdb_remote_client/TestGDBRemotePlatformFile

The tests `test_file_permissions` and `test_file_permissions_fallback` are disabled for Windows target. These tests use MockGDBServerResponder and do not depend on the real target. These tests failed in case of Windows host and Linux target. Disable them for Windows host too.
---
 .../gdb_remote_client/TestGDBRemotePlatformFile.py              | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py b/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
index 2be5ae3132038..9ef0954af1fe3 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
@@ -148,6 +148,7 @@ def vFile(self, packet):
         )
 
     @skipIfWindows
+    @skipIf(hostoslist=["windows"])
     def test_file_permissions(self):
         """Test 'platform get-permissions'"""
 
@@ -168,6 +169,7 @@ def vFile(self, packet):
         )
 
     @skipIfWindows
+    @skipIf(hostoslist=["windows"])
     def test_file_permissions_fallback(self):
         """Test 'platform get-permissions' fallback to fstat"""
 

>From 478d251691d511916cae5fc344d549450222d584 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
Date: Tue, 14 May 2024 20:23:56 +0400
Subject: [PATCH 2/2] Removed @skipIfWindows

---
 .../gdb_remote_client/TestGDBRemotePlatformFile.py              | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py b/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
index 9ef0954af1fe3..b1c6f0822d1a8 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
@@ -147,7 +147,6 @@ def vFile(self, packet):
             log=server2.responder.packetLog,
         )
 
-    @skipIfWindows
     @skipIf(hostoslist=["windows"])
     def test_file_permissions(self):
         """Test 'platform get-permissions'"""
@@ -168,7 +167,6 @@ def vFile(self, packet):
             ]
         )
 
-    @skipIfWindows
     @skipIf(hostoslist=["windows"])
     def test_file_permissions_fallback(self):
         """Test 'platform get-permissions' fallback to fstat"""