[Lldb-commits] [lldb] [lldb][Windows] Fixed the test gdb_remote_client/TestGDBRemotePlatformFile (PR #92088)

via lldb-commits lldb-commits at lists.llvm.org
Tue May 14 02:09:56 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

<details>
<summary>Changes</summary>

The tests `test_file_permissions` and `test_file_permissions_fallback` are disabled for Windows target. These tests use MockGDBServerResponder and do not depend on the real target. These tests failed in case of Windows host and Linux target. Disable them for Windows host too.

---
Full diff: https://github.com/llvm/llvm-project/pull/92088.diff


1 Files Affected:

- (modified) lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py (+2) 


``````````diff
diff --git a/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py b/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
index 2be5ae3132038..9ef0954af1fe3 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestGDBRemotePlatformFile.py
@@ -148,6 +148,7 @@ def vFile(self, packet):
         )
 
     @skipIfWindows
+    @skipIf(hostoslist=["windows"])
     def test_file_permissions(self):
         """Test 'platform get-permissions'"""
 
@@ -168,6 +169,7 @@ def vFile(self, packet):
         )
 
     @skipIfWindows
+    @skipIf(hostoslist=["windows"])
     def test_file_permissions_fallback(self):
         """Test 'platform get-permissions' fallback to fstat"""
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/92088


More information about the lldb-commits mailing list