[Lldb-commits] [lldb] [lldb] Fixed the test TestThreadStates when run with a remote target (PR #92086)

Dmitry Vasilyev via lldb-commits lldb-commits at lists.llvm.org
Tue May 14 01:52:48 PDT 2024


https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/92086

self.wait_for_running_event(process) is always called after self.runCmd("continue"). It is strange to expect eStateConnected here. This test failed in case of a remote target. The correct state is eStateRunning. Removed incorrect checking.

>From 27df461f6a03581cdcdb6911a943e694125061ee Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
Date: Tue, 14 May 2024 12:52:20 +0400
Subject: [PATCH] [lldb] Fixed the test TestThreadStates when run with a remote
 target

self.wait_for_running_event(process) is always called after self.runCmd("continue").
It is strange to expect eStateConnected here. This test failed in case of a remote target.
The correct state is eStateRunning. Removed incorrect checking.
---
 .../test/API/functionalities/thread/state/TestThreadStates.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lldb/test/API/functionalities/thread/state/TestThreadStates.py b/lldb/test/API/functionalities/thread/state/TestThreadStates.py
index f4c17df523382..4dbe230c0ce85 100644
--- a/lldb/test/API/functionalities/thread/state/TestThreadStates.py
+++ b/lldb/test/API/functionalities/thread/state/TestThreadStates.py
@@ -102,10 +102,6 @@ def thread_state_after_breakpoint_test(self):
 
     def wait_for_running_event(self, process):
         listener = self.dbg.GetListener()
-        if lldb.remote_platform:
-            lldbutil.expect_state_changes(
-                self, listener, process, [lldb.eStateConnected]
-            )
         lldbutil.expect_state_changes(self, listener, process, [lldb.eStateRunning])
 
     def thread_state_after_continue_test(self):



More information about the lldb-commits mailing list