[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

[via lldb-commits]

jimingham wrote:



> On May 13, 2024, at 6:04 PM, Zequan Wu ***@***.***> wrote:
> 
> 
> I was able to reproduce the failure of these three:
> 
> lldb-api :: lang/c/forward/TestForwardDeclaration.py
> lldb-api :: lang/cpp/unique-types3/TestUniqueTypes3.py
> lldb-api :: types/TestRecursiveTypes.py
> 
> locally. Reverting this patch and a7eff59 <https://github.com/llvm/llvm-project/commit/a7eff59f78f08f8ef0487dfe2a136fb311af4fd0> which depended on it made the failure go away.
> 
> I reverted the patches for now to get the bots clean.
> 
> Thanks. Can you provide instructions to repro the failure locally?
> 
I didn't do anything out of the ordinary.  I'm on macOS Sonoma 14.4.1, with the latest Xcode(15.3).  I ran the CMakery this way:

cmake -B `pwd`/all-in-one -G Ninja -C `pwd`/llvm-project/lldb/cmake/caches/Apple-lldb-base.cmake -DLLVM_ENABLE_PROJECTS="clang;lldb" -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;compiler-rt;libunwind" -DLIBCXX_INCLUDE_TESTS=OFF  -DCMAKE_BUILD_TYPE=Debug -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=12.3  -DLLDB_BUILD_FRAMEWORK=YES  -DCMAKE_CXX_STANDARD:STRING=17 llvm-project/llvm

Then:

$ cd all-in-one
$ ninja check-lldb

and got the failure.

Jim


> @ZequanWu <https://github.com/ZequanWu> in the future, if one of your commits break a bot, make sure to revert it immediately, you can always re-land it later with a fix or an explanation why it wasn't your commit that broke the bots. Reverting a commit is cheap, red bots are expensive :-)
> 
> Will do.
> 
> —
> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/90663#issuecomment-2109081326>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW2VA2CFK2NIEANWQG3ZCFPJJAVCNFSM6AAAAABHA7HMYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZGA4DCMZSGY>.
> You are receiving this because you are on a team that was mentioned.
> 



https://github.com/llvm/llvm-project/pull/90663