[Lldb-commits] [lldb] [lldb][Windows] Enforce exec permission using Platform::Install() from Windows host (PR #91887)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon May 13 03:36:05 PDT 2024


labath wrote:

The `ifdef` in the generic code is not exactly ideal, and I'm wondering if we should just do the same thing as Target::Install does (i.e., set the execute flag unconditionally). Looking at the history, it appears that the Target::Install code was [introduced](https://reviews.llvm.org/D9492) to fix the same problem you are having, and it's quite possible this code path was not noticed because we were still in the very early stages of cross-debugging bringup (or the function did even not exist back then).

In fact, if I'm reading this correctly, you should be able to remove the Target::Install workaround if you put the code here.

WDYT?

https://github.com/llvm/llvm-project/pull/91887


More information about the lldb-commits mailing list