[Lldb-commits] [lldb] [lldb] Fixed the test TestQuoting (PR #91886)
Dmitry Vasilyev via lldb-commits
lldb-commits at lists.llvm.org
Sun May 12 07:35:26 PDT 2024
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/91886
>From f6135c1b825afd9fe733b845dfd12ffe3c162840 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
Date: Sun, 12 May 2024 18:08:50 +0400
Subject: [PATCH 1/2] [lldb] Fixed the test TestQuoting
os.path.join() uses the path separator of the host OS by default. outfile_arg will be incorrect in case of Windows host and Linux target. Use lldbutil.append_to_process_working_directory() instead.
---
lldb/test/API/commands/settings/quoting/TestQuoting.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lldb/test/API/commands/settings/quoting/TestQuoting.py b/lldb/test/API/commands/settings/quoting/TestQuoting.py
index 393f4be3c8242..d6246a5309c5d 100644
--- a/lldb/test/API/commands/settings/quoting/TestQuoting.py
+++ b/lldb/test/API/commands/settings/quoting/TestQuoting.py
@@ -51,8 +51,8 @@ def expect_args(self, args_in, args_out):
outfile = self.getBuildArtifact(filename)
if lldb.remote_platform:
- outfile_arg = os.path.join(
- lldb.remote_platform.GetWorkingDirectory(), filename
+ outfile_arg = lldbutil.append_to_process_working_directory(
+ self, filename
)
else:
outfile_arg = outfile
>From ff85c4d9cb0c749fe75be1493dd22b7f7c0de9be Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
Date: Sun, 12 May 2024 18:35:12 +0400
Subject: [PATCH 2/2] Updated the formatting by darker
---
lldb/test/API/commands/settings/quoting/TestQuoting.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lldb/test/API/commands/settings/quoting/TestQuoting.py b/lldb/test/API/commands/settings/quoting/TestQuoting.py
index d6246a5309c5d..60eeeead4e0a4 100644
--- a/lldb/test/API/commands/settings/quoting/TestQuoting.py
+++ b/lldb/test/API/commands/settings/quoting/TestQuoting.py
@@ -51,9 +51,7 @@ def expect_args(self, args_in, args_out):
outfile = self.getBuildArtifact(filename)
if lldb.remote_platform:
- outfile_arg = lldbutil.append_to_process_working_directory(
- self, filename
- )
+ outfile_arg = lldbutil.append_to_process_working_directory(self, filename)
else:
outfile_arg = outfile
More information about the lldb-commits
mailing list