[Lldb-commits] [lldb] [lldb] Add ability to show enum as name and value at the same time (PR #90059)
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Fri May 10 11:27:04 PDT 2024
https://github.com/clayborg requested changes to this pull request.
So each `ValueObject` has the ability to show its value as an enumeration if its format is set to `eFormatEnum`. If the format is set to `eFormatHex`, `eFormatUnsigned`, or `eFormatSigned`, then we show the numeric value.
Can you show some sample output for this? I would like the `const char *SBValue::GetValue()` function to obey the format that is selected and not return something that has both inside of it. It would be ok for the `const char *SBValue::GetSummary()` to return the enumeration if the format isn't set to `eFormatEnum`.
This makes me question the need for the `ValueObject::SetEnumsAlwaysShowValue()` and `ValueObject::GetEnumsAlwaysShowValue()` methods, the ivars they use and many of the other changes here.
https://github.com/llvm/llvm-project/pull/90059
More information about the lldb-commits
mailing list