[Lldb-commits] [lldb] [lldb/crashlog] Fix module binary resolution (PR #91631)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu May 9 11:01:57 PDT 2024


================
@@ -418,9 +418,22 @@ def locate_module_and_debug_symbols(self):
                         with print_lock:
                             print('falling back to binary inside "%s"' % dsym)
                         self.symfile = dsym
-                        for filename in os.listdir(dwarf_dir):
-                            self.path = os.path.join(dwarf_dir, filename)
-                            if self.find_matching_slice():
+                        # Look for the executable next to the dSYM bundle.
+                        parent_dir = os.path.dirname(dsym)
+                        find_results = (
+                            subprocess.check_output(
+                                '/usr/bin/find "%s" -type f \( -perm -u=x -o -perm -g=x -o -perm -o=x \)'
----------------
JDevlieghere wrote:

Rather than shelling out to find, can you use `os.walk`? 

https://github.com/llvm/llvm-project/pull/91631


More information about the lldb-commits mailing list