[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy	(PR #91109)
    Alex Langford via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Wed May  8 11:17:07 PDT 2024
    
    
  
================
@@ -526,6 +526,47 @@ def create_target(self):
     def get_target(self):
         return self.target
 
+    def load_images(self, options, loaded_images=[]):
----------------
bulbazord wrote:
Suggestion: Default `loaded_images` to `None`. You probably don't want `loaded_images` to default to `[]`. It will persist between calls, e.g.:
```
>>> def foo(x, lst=[]):
...     lst.append(x)
...     print(lst)
...
>>> foo(1)
[1]
>>> foo(2)
[1, 2]
```
https://github.com/llvm/llvm-project/pull/91109
    
    
More information about the lldb-commits
mailing list