[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

via lldb-commits lldb-commits at lists.llvm.org
Tue May 7 18:13:22 PDT 2024


jimingham wrote:

Sounds good to me.

Jim


> On May 7, 2024, at 4:52 PM, royitaqi ***@***.***> wrote:
> 
> 
> Hi @jimingham <https://github.com/jimingham>,
> 
> Thank you so much for the detailed explanation about the context and your thoughts. I appreciate it.
> 
> Good to know about the automated scripts and that you personally never used the existing transcript. It makes me feel that there are distinctively different use cases, and for the ones where the user know they won't need the transcript, they should be able to turn them off (and yes the text output can be large if someone opt to print e.g. statistics dump).
> 
> As a matter of fact, that's a better design since then I can disable the feature temporarily without having to mess up the settings I want when I do do it.
> 
> This is also an interesting design aspect that I never thought about. This is good learning.
> 
> --
> 
> Overall I feel what you said makes sense. I will open a follow-up PR specifically for the settings, where we can discuss more (e.g. default on or off; should the setting turn off the existing transcript; should we add a interpreter.save-session-format; etc).
> 
>> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/90703#issuecomment-2099490330>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW3UEZVXIJWIB64IBITZBFSNTAVCNFSM6AAAAABHBPBMWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGQ4TAMZTGA>.
> You are receiving this because you were mentioned.
> 



https://github.com/llvm/llvm-project/pull/90703


More information about the lldb-commits mailing list