[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

[via lldb-commits]

royitaqi wrote:

@jimingham 

> Adding debuggers, or querying them is controlled by the debugger list mutex.  Manipulating the I/O handlers is governed by the io handler stack mutex, there's a lock around the interrupt requests.  Debugger doesn't seem like a class that is not locking the lists of things it controls as a general rule.

This is fair. I somehow missed them the last time I was searching for mutex in the same code.

--

With the above, I'm on the fence. Since I have less knowledge and context, at this point I will depend on @jimingham & @JDevlieghere you guys aligning with each other and pointing me in the right direction. LMK. Either ways it should be an easy change in the PR (since we already have thread-safety implemented).

https://github.com/llvm/llvm-project/pull/89868