[Lldb-commits] [lldb] [lldb][DWARF] Sort ranges list in dwarf 5. (PR #91343)
Zequan Wu via lldb-commits
lldb-commits at lists.llvm.org
Tue May 7 10:59:44 PDT 2024
ZequanWu wrote:
> > Some places assume the ranges are already sorted but it's not. This fixes it.
>
> What places assumed it was sorted? I assume this means there are some bugs that this fixes? Can you give some more details about how you came to write this patch?
For example: https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp#L922-L927.
When parsing function info, it validates low and hi address of the function: `GetMinRangeBase` returns the first range entry base and `GetMaxRangeEnd` returns the last range end. If low >= hi, it stops parsing this function.
This causes missing inline stack frames for us when debugging a core dump.
https://github.com/llvm/llvm-project/pull/91343
More information about the lldb-commits
mailing list