[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

Zequan Wu via lldb-commits lldb-commits at lists.llvm.org
Fri May 3 10:39:39 PDT 2024


ZequanWu wrote:

> > > Is any of it testable?
> > 
> > 
> > Good question. Though this is mostly meant to be "NFC" (with very large quotes), I can imagine us doing something like forcing the parsing of a specific type (`type lookup <something>` ?), and then checking that the module ast (`image dump ast`) does _not_ contain specific types -- as that's basically what we're trying to achieve.
> 
> Yea that could work. But if it's going to be very painful or fragile to test then don't let that hold back the PR

In terms of testing, since this only delays definition DIE searching not type completion, we need to construct a test so that lldb finds the declaration DIE first without trigger a type completion on it and somehow test the incomplete type. The first part is tricky. I'm not sure how to achieve it.

https://github.com/llvm/llvm-project/pull/90663


More information about the lldb-commits mailing list